Effectively reverse proxy deployments for updates #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to our deployment
Contributor
|
Uu, this seems like a lot of code to deploy a pod. Did we consider deploying the reverse proxy directly to the frontend namespace via "classic" means? I feel like we are writing a lot of operator code that could be replaced by a fairly small deployment config. Unless there is a specific reason why we can't? |
florkbr
reviewed
Oct 1, 2025
| for _, change := range changes { | ||
| r.Log.Info("Applying container change", "field", change.Field, "reason", change.Reason) | ||
|
|
||
| switch change.Field { |
Contributor
There was a problem hiding this comment.
@justinorringer FWIW there is no default case or error handling if the change requested is not recognized.
florkbr
reviewed
Oct 1, 2025
|
|
||
| envVars := []v1.EnvVar{ | ||
| {Name: "SERVER_PORT", Value: strconv.Itoa(ReverseProxyPort)}, | ||
| {Name: "MINIO_UPSTREAM_URL", Value: minioUpstreamURL}, |
Contributor
There was a problem hiding this comment.
We should probably rename this VAR at some point in the RP. Seems odd to use in prod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the reverse proxy, whenever each frontend appears, tries to create a new container to compare with the current one, then cleans up the old. Whenever the operator rolls out for example, there are a lot of comparisons.
Instead we should do it more like this comparing fields.
In the future, we should make an utility to do these comparisons and manage if the pod should be restarted or not...